[libcamera-devel] [PATCH v1 1/1] utils: ipc: Update parser.py

Kieran Bingham kieran.bingham at ideasonboard.com
Fri Mar 31 14:32:48 CEST 2023


Hi Harvey,

Quoting Harvey Yang via libcamera-devel (2023-03-31 09:45:45)
> Make the local mojom library the first priority in the sys path, to
> avoid mixing the local one with the system one in build.
> 
> Tested on chromebook soraka-libcamera.
> 
> Signed-off-by: Harvey Yang <chenghaoyang at chromium.org>

This looks reasonable to me, And easier to handle than the larger more
invasive change:

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  utils/ipc/parser.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/ipc/parser.py b/utils/ipc/parser.py
> index f46820fa..231a3266 100755
> --- a/utils/ipc/parser.py
> +++ b/utils/ipc/parser.py
> @@ -13,7 +13,7 @@ import sys
>  sys.dont_write_bytecode = True
>  
>  # Make sure that mojom_parser.py can import mojom
> -sys.path.append(f'{os.path.dirname(__file__)}/mojo/public/tools/mojom')
> +sys.path.insert(0, f'{os.path.dirname(__file__)}/mojo/public/tools/mojom')
>  
>  import mojo.public.tools.mojom.mojom_parser as parser
>  
> -- 
> 2.40.0.348.gf938b09366-goog
>


More information about the libcamera-devel mailing list