[libcamera-devel] [PATCH 11/13] pipeline: raspberrypi: Make RPi::Stream::name() return const std::string &
Naushir Patuck
naush at raspberrypi.com
Wed May 3 14:20:33 CEST 2023
Return a const std::string reference from RPi::Stream::name() to avoid
copying a string when not needed.
Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
src/libcamera/pipeline/rpi/common/rpi_stream.cpp | 2 +-
src/libcamera/pipeline/rpi/common/rpi_stream.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/libcamera/pipeline/rpi/common/rpi_stream.cpp b/src/libcamera/pipeline/rpi/common/rpi_stream.cpp
index 3690667e9aa6..b7e4130f5e56 100644
--- a/src/libcamera/pipeline/rpi/common/rpi_stream.cpp
+++ b/src/libcamera/pipeline/rpi/common/rpi_stream.cpp
@@ -19,7 +19,7 @@ V4L2VideoDevice *Stream::dev() const
return dev_.get();
}
-std::string Stream::name() const
+const std::string &Stream::name() const
{
return name_;
}
diff --git a/src/libcamera/pipeline/rpi/common/rpi_stream.h b/src/libcamera/pipeline/rpi/common/rpi_stream.h
index 1aae674967e1..b8c74de35863 100644
--- a/src/libcamera/pipeline/rpi/common/rpi_stream.h
+++ b/src/libcamera/pipeline/rpi/common/rpi_stream.h
@@ -49,7 +49,7 @@ public:
}
V4L2VideoDevice *dev() const;
- std::string name() const;
+ const std::string &name() const;
bool isImporter() const;
void resetBuffers();
--
2.34.1
More information about the libcamera-devel
mailing list