[libcamera-devel] [PATCH 1/2] libcamera: ipa_manager: Only parse IPA modules

[Kieran Bingham]

Quoting Javier Martinez Canillas (2023-05-03 13:55:02)
> On 5/1/23 17:55, Kieran Bingham wrote:
> > Ensure that when we iterate the libcamera libdir we only select shared
> > objects which are expected to be IPA modules, with an ipa_ prefix.
> > 
> > Any shared object not matching this filter is ignored and not processed
> > by the IPA Manager.
> > 
> > Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> > ---
> 
> Was this only needed for patch #2 that was adding the v4l2-compat.so in
> the same directory where the IPA modules are installed? I guess that it

Yes. ... 

> makes sense in general to have this filter, but maybe another option is

Yes I think it still makes sense as an extra check...

> to move all the IPA modules to a $libdir/libcamera/ipa sub-directory ?

And yes, I think this also makes sense too!

--
Kieran


> 
> -- 
> Best regards,
> 
> Javier Martinez Canillas
> Core Platforms
> Red Hat
>