[libcamera-devel] [PATCH 3/3] libcamera: pipeline: Register device numbers with camera

[Barnabás Pőcze]

Hi


2023. május 3., szerda 16:02 keltezéssel, Kieran Bingham <kieran.bingham at ideasonboard.com> írta:

> [...]
> > > +     /*
> > > +      * Store the associated devices as a property of the camera to allow
> > > +      * systems to identify which devices are managed by libcamera.
> > > +      */
> > > +     Camera::Private *data = camera->_d();
> > > +     data->properties_.set(properties::Devices, devnums);
> >
> > I am getting an assertion failure while testing https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/1611
> >
> >   ASSERT(elementSize == ControlValueSize[type]);
> >
> > in `controls.cpp:ControlValue::set()` fails because `sizeof(dev_t) != 4`.
> 
> Yes, this is fixed ready for a V2 ... but the first patch needs to use a
> 64 bit integer, not a 32 bit.

I see, thanks for the clarification. These patches were linked in the pipewire MR
and I couldn't find a newer version. I presume it is not posted yet? As far as I
am aware `dev_t` is 64-bit on most(?) Linux platforms, so I don't understand
the remark regarding the first patch.


> [...]


Regards,
Barnabás Pőcze