[libcamera-devel] [PATCH] v4l2: Add soversion to the V4L2 layer

[Javier Martinez Canillas]

Laurent Pinchart <laurent.pinchart at ideasonboard.com> writes:
> On Thu, May 04, 2023 at 12:10:49AM +0100, Kieran Bingham wrote:

[...]

>> > This discussion and patch stem from a Fedora packaging rule that forbids
>> > unversioned shared object libraries in $libdir/ for non -devel packages.
>> > Maybe the patch you sent to move v4l2-compat.so to $libdir/libcamera
>> > could be enough to satisfy the packaging rules, without needing to
>> > version v4l2-compat.so ? Btw, Javier mentioned on IRC it should actually
>> > go to $libexecdir/libcamera, but let's discuss that in the review of
>> > your other patch.
>> 
>> It sounds like you're on the Nack side. Do you actively object to this
>> because you see harm in versioning the sofile?
>> 
>> Even if we move it to libexec, or lib/libcamera/ or anywhere else, I
>> can't see why it can not be versioned the same as libcamera.
>
> I'm not necessarily against it. All I want is to consider the big
> picture of how all this will be packaged, to make sure we implement
> something useful for distributions.
>

As another data point, none of the shared libraries I currently have
installed in /usr/libexec/ have a versioned SONAME.

If v4l2-compat.so is moved there, then IMO we should just drop this
patch since the lib will only be used by libcamerify. And as Laurent
mentioned, that isn't parallel installable anyways.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat