[libcamera-devel] [PATCH v2 3/4] libcamera: properties: Provide a Devices camera property

[Kieran Bingham]

Quoting Jacopo Mondi (2023-05-13 16:03:07)
> Hi Kieran
> 
> On Thu, May 11, 2023 at 11:58:32PM +0100, Kieran Bingham via libcamera-devel wrote:
> > Provide a new Camera property that allows pipeline handlers to list any
> > devices used to operate the device. This allows other frameworks and
> > daemons such as Pipewire to better understand the resources consumed by
> > a Camera and consider ignoring those resources when enumerating camera
> > devices on a system.
> >
> > Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> > ---
> >  src/libcamera/property_ids.yaml | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> > index cb55e0ed2283..4fed8f862efb 100644
> > --- a/src/libcamera/property_ids.yaml
> > +++ b/src/libcamera/property_ids.yaml
> > @@ -690,6 +690,14 @@ controls:
> >          that is twice that of the full resolution mode. This value will be valid
> >          after the configure method has returned successfully.
> >
> > +
> 
> Additional blank line ?

Ha, I thought that was intentional when I looked at this before I sent,
but indeed the others are separated by single lines so this is excess.

Will remove.


> 
> With this fixed:
> Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
> 
> 
> > +  - Devices:
> > +      type: int64_t
> > +      size: [n]
> > +      description: |
> > +        A list of integer values of type dev_t denoting major and minor device
> > +        number of the underlying devices used in the operation of this camera.
> > +
> >    # ----------------------------------------------------------------------------
> >    # Draft properties section
> >
> > --
> > 2.34.1
> >