[libcamera-devel] [PATCH v5 0/1] HDR controls

[Laurent Pinchart]

Hi David,

On Thu, Oct 26, 2023 at 12:11:30PM +0100, David Plowman via libcamera-devel wrote:
> Hi
> 
> Version 5 is mostly trying to be more specific about the descriptions,
> concentrating in the main on what the normal or default
> implementations might do (before anyone dives in and alters the
> behaviour). I have a few little niggles:
> 
> * The night mode is still a bit vague. I don't have much of a feel for
>   whether there is a reasonable default behaviour for this. I suppose
>   we could just say that frames are labelled long/medium/short
>   according to the implementation?

I'll check patch 1/1 and will comment there.

> * I've said vaguely that frames cycle between short/long or
>   short/medium/long according to the implementation. Do we need to be
>   signalling which category an implementation falls into?

Maybe in the future, but for now I think it's fine.

> * There's no clear reason why HdrChannelNone exists. I do believe it
>   is useful

I have a bit of trouble not reading this is a contradiction :-)

> , not just for Pi users who might want to mess around and
>   do unusual things, but also when switching exposures reliably from
>   frame to frame proves difficult (because it is quite hard to do
>   right).

I think I'm fine keeping it and see where it will lead us.

> David Plowman (1):
>   libcamera: controls: Add controls for HDR
> 
>  src/libcamera/control_ids.yaml | 87 ++++++++++++++++++++++++++++++++++
>  1 file changed, 87 insertions(+)

-- 
Regards,

Laurent Pinchart