[libcamera-devel] [PATCH] gstreamer: Implement EOS handling

[Nicolas Dufresne]

Hi Jaslo,

Le vendredi 10 novembre 2023 à 12:00 +0100, Jaslo Ziska a écrit :
> > 
> > This patch does not cover (and this can be done 
> > later/seperatly):
> > 
> >    libcamerasrc ! identity eos-after=10 ! fakesink
> > 
> > Which is the case when downstream decides to stop. This case is 
> > a
> > little more complex for multi-pad elements and is actually nice 
> > to
> > tackle separately (its also more niche).
> 
> Isn't this already implemented when checking for GST_FLOW_EOS in 
> GstLibcameraSrcState::processRequest()? Or is this something else?

You are correct, my bad. I didn't realize we had some handling. I'm not sure its
done properly though, since it seems pretty unfortunate that one FLOW_EOS on one
streams causes all streams to abort. I'd need to check demuxers, tee, rtspsrc
and other implementation to understand what is expected.

> 
> Regards,
> 
> Jaslo

Nicolas