[libcamera-devel] [PATCH v2] gstreamer: Fix unused variable error

[Umang Jain]

Hi Laurent,

Thank you for handling this.

On 11/23/23 1:27 PM, Laurent Pinchart via libcamera-devel wrote:
> From: Jaslo Ziska <jaslo at ziska.de>
>
> Commit fd84180d7a09 ("gstreamer: Implement element EOS handling") has
> introduced a compilation warning with clang:
>
> ../../src/gstreamer/gstlibcamerasrc.cpp:768:23: error: unused variable 'oldEvent' [-Werror,-Wunused-variable]
>                  g_autoptr(GstEvent) oldEvent = self->pending_eos.exchange(event);
>                                      ^
>
> This seems to be a false positive, but nonetheless breaks the build. Fix
> it.
>
> Fixes: fd84180d7a09 ("gstreamer: Implement element EOS handling")
> Signed-off-by: Jaslo Ziska <jaslo at ziska.de>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>

> ---
>   src/gstreamer/gstlibcamerasrc.cpp | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp
> index 767017db63f5..a6f240f56873 100644
> --- a/src/gstreamer/gstlibcamerasrc.cpp
> +++ b/src/gstreamer/gstlibcamerasrc.cpp
> @@ -765,8 +765,8 @@ gst_libcamera_src_send_event(GstElement *element, GstEvent *event)
>   
>   	switch (GST_EVENT_TYPE(event)) {
>   	case GST_EVENT_EOS: {
> -		g_autoptr(GstEvent) oldEvent = self->pending_eos.exchange(event);
> -
> +		GstEvent *oldEvent = self->pending_eos.exchange(event);
> +		gst_clear_event(&oldEvent);
>   		ret = TRUE;
>   		break;
>   	}
>
> base-commit: 2fae9603e6cc483d9d0d74868721b272776513cf