[libcamera-devel] [PATCH v3] gstreamer: Implement element EOS handling

[Kieran Bingham]

Quoting Nicolas Dufresne (2023-11-23 15:49:29)
> Le jeudi 23 novembre 2023 à 10:14 +0530, Umang Jain a écrit :
> > Hi,
> > > > > 2023. november 22., szerda 18:08 keltezéssel, Kieran Bingham via libcamera-devel <libcamera-devel at lists.libcamera.org> írta:
> > > > > > 
> > > > > > I'm afraid with a broken build we're blocked on merging more patches -
> > > > > > of which I'm now trying to do - so I'd probably ask if we can revert
> > > > > > this until it's fixed please.
> > > > > > [...]
> > > > > [[maybe_unused]] g_autoptr(GstEvent) oldEvent = self->pending_eos.exchange(event);
> > > > Or just, like the original patch did.
> > > > 
> > > >     GstEvent *oldEvent = self->pending_eos.exchange(event);
> > > >     gst_clear_event(&oldEvent);
> > > > 
> > > > Not sure why this blocks anything, sounds a bit dramatic handling of a build
> > > > warning. In this case, its quite obvious that this is a false positive in clang
> > > > warning machinery, you will hit more of these with clang in my experience.
> > > Sorry, it wasn't supposed to be dramatic. A real fix is fine too, but a
> > > revert and re-apply fixed isnt hard either.
> > 
> > I will post a revert and a re-appllied patch for review.
> 
> I'll start being annoying, but why all this complexity needed ? Why not just
> make a patch that fix the previous one, you add add "fixes" tag to make it
> clear.

Yeah - mailing lists are rubbish ... if only this was all in a single
thread or context and everything was in one place, then the final result
here would have been more obvious...

https://patchwork.libcamera.org/patch/19230/

--
Kieran