[libcamera-devel] [PATCH v3 6/7] build: controls: Add Raspberry Pi vendor specific controls

[Jacopo Mondi]

Hi Naush

On Fri, Nov 24, 2023 at 12:37:12PM +0000, Naushir Patuck via libcamera-devel wrote:
> Add a new control_ids_rpi.yaml file to hold the Raspberry Pi specific
> vendor controls. This contains a single control PispConfigDumpFile that
> will be used in the Pi 5 pipeline handler as a trigger to dump the
> Backend configuration as a JSON file.
>
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> ---
>  include/libcamera/meson.build      |  2 ++
>  src/libcamera/control_ids_rpi.yaml | 17 +++++++++++++++++
>  2 files changed, 19 insertions(+)
>  create mode 100644 src/libcamera/control_ids_rpi.yaml
>
> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build
> index 1504f741ae2f..5d20e4d869e3 100644
> --- a/include/libcamera/meson.build
> +++ b/include/libcamera/meson.build
> @@ -36,6 +36,8 @@ controls_map = {
>      'controls': {
>          'draft': 'control_ids_draft.yaml',
>          'core': 'control_ids_core.yaml',
> +        'rpi/pisp': 'control_ids_rpi.yaml',

Not mainline yet, but I guess it doesn't hurt :)

Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>

> +        'rpi/vc4': 'control_ids_rpi.yaml',
>      },
>
>      'properties': {
> diff --git a/src/libcamera/control_ids_rpi.yaml b/src/libcamera/control_ids_rpi.yaml
> new file mode 100644
> index 000000000000..abf82098eb12
> --- /dev/null
> +++ b/src/libcamera/control_ids_rpi.yaml
> @@ -0,0 +1,17 @@
> +# SPDX-License-Identifier: LGPL-2.1-or-later
> +#
> +# Copyright (C) 2023, Raspberry Pi Ltd
> +#
> +%YAML 1.1
> +---
> +# Raspberry Pi (VC4 and PiSP) specific vendor controls
> +vendor: rpi
> +controls:
> +  - PispConfigDumpFile:
> +      type: string
> +      description: |
> +        Triggers the Raspberry Pi PiSP pipeline handler to generate a JSON
> +        formatted dump of the Backend configuration to the filename given by the
> +        value of the control.
> +
> +...
> \ No newline at end of file
> --
> 2.34.1
>