[libcamera-devel] [PATCH v2 1/2] libcamera: controls: Update the ColourTemperature control to be writable

[Kieran Bingham]

Quoting David Plowman via libcamera-devel (2023-11-23 13:09:04)
> Implementations are allowed to expose this as a settable control so
> that applications can demand a specific colour temperature. The
> description is updated to this effect.
> 
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
> ---
>  src/libcamera/control_ids.yaml | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
> index c3232abf..8fbcc5f6 100644
> --- a/src/libcamera/control_ids.yaml
> +++ b/src/libcamera/control_ids.yaml
> @@ -312,9 +312,11 @@ controls:
>  
>    - ColourTemperature:
>        type: int32_t
> -      description: Report the current estimate of the colour temperature, in
> -        kelvin, for this frame. The ColourTemperature control can only be
> -        returned in metadata.
> +      description: |
> +        Report the current estimate of the colour temperature, in kelvin, for
> +        this frame. An implementation may also allow this control to be set so
> +        as to disable the AWB algorithm whilst setting the colour gains to the
> +        correct fixed ones for this colour temperature.

This certainly frames it as a mostly metadata control rather than a
control-control. So I think that's fine as that's possibly the
expectation for the most part.

I have in mind to do some documentation udpates in the near future so I
wonder if I should look through all the controls and normalise how we
present the descriptions if they are read-only or settable or only
if supported by the pipeline handler...

But I don't object to this for now so:

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

>  
>    - Saturation:
>        type: float
> -- 
> 2.39.2
>