[libcamera-devel] [PATCH v2 0/3] gstreamer: Implement renegotiation

Jaslo Ziska jaslo at ziska.de
Thu Nov 30 16:43:07 CET 2023


Hi,

in this revision I mostly implemented Nicolas' suggestions namely
writing a comment on the locking behaviour for
gst_libcamera_src_negotiate and using the correct types and putting
the addition of the clearRequests function into a seperate commit.
Also the gst_libcamera_src_negotiate function now clears the
reconfigure flag and thus not all pads need to be iterated when
checking for this flag in the running task.

Another thing I changed is that in processRequest in the
GST_FLOW_NOT_NEGOTIATED case it is now checked whether any pad
actually requested a renegotiation and if not an error is returned.

Regards,

Jaslo

Jaslo Ziska (3):
  gstreamer: Move negotiation logic to separate function
  gstreamer: Add GstLibcameraSrcState::clearRequests method
  gstreamer: Implement renegotiation

 src/gstreamer/gstlibcamerasrc.cpp | 263 ++++++++++++++++++------------
 1 file changed, 158 insertions(+), 105 deletions(-)

--
2.43.0


More information about the libcamera-devel mailing list