[libcamera-devel] [PATCH 20/20] ipa: rpi: agc: When AGC channels are changed, start with the 1st channel

[Jacopo Mondi]

Hi Naush

On Fri, Oct 06, 2023 at 02:20:00PM +0100, Naushir Patuck via libcamera-devel wrote:
> Whenever the AGC active channels are changed, start with the first
> channel listed. This allows applications to rely on a particular channel
> being generated first. For example, multi-exposure HDR always wants the
> short channel first.

The user won't be able to cycle through channels directly, but the HDR
algorithm will, right ? So this doesn't need to be documented anywhere
perhaps...

>
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> Reviewed-by: David Plowman <david.plowman at raspberrypi.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>

Thanks
  j

> ---
>  src/ipa/rpi/controller/rpi/agc.cpp | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/ipa/rpi/controller/rpi/agc.cpp b/src/ipa/rpi/controller/rpi/agc.cpp
> index 758da0719b9b..32eb36242268 100644
> --- a/src/ipa/rpi/controller/rpi/agc.cpp
> +++ b/src/ipa/rpi/controller/rpi/agc.cpp
> @@ -203,6 +203,7 @@ void Agc::setActiveChannels(const std::vector<unsigned int> &activeChannels)
>
>  	LOG(RPiAgc, Debug) << "setActiveChannels " << activeChannels;
>  	activeChannels_ = activeChannels;
> +	index_ = 0;
>  }
>
>  void Agc::switchMode(CameraMode const &cameraMode,
> --
> 2.34.1
>