[libcamera-devel] [GIT PULL] Raspberry Pi: Preliminary PiSP support (round 2)

[Kieran Bingham]

Hi Naush,

Quoting Naushir Patuck (2023-10-24 10:24:27)
> The following changes since commit b5f5a89bc34c601d9b59e160af9db557e1443904:
> 
>   apps: qcam: Add support for RGB565 (2023-10-23 13:50:18 +0300)
> 
> are available in the Git repository at:
> 
>   https://github.com/naushir/libcamera.git HEAD
> 
> for you to fetch changes up to a9ac7f410e8f53dd580d83cb096c9f4b24e6b77c:

I've had to rebase this to the latest master. That then requires my
signoff, so I also took the opportunity to fix a small checkstyle
warning that looked more correct to me:

diff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp
index 354b901bb796..c4baf04fb1e7 100644
--- a/src/ipa/rpi/vc4/vc4.cpp
+++ b/src/ipa/rpi/vc4/vc4.cpp
@@ -266,7 +266,7 @@ void IpaVc4::handleControls(const ControlList &controls)
 			/* Some platforms may have a combined "denoise" algorithm instead. */
 			if (!sdn)
 				sdn = dynamic_cast<RPiController::DenoiseAlgorithm *>(
-				controller_.getAlgorithm("denoise"));
+					controller_.getAlgorithm("denoise"));
 			if (!sdn) {
 				LOG(IPARPI, Warning)
 					<< "Could not set NOISE_REDUCTION_MODE - no SDN algorithm";

--
Regards

Kieran


> 
>   ipa: rpi: agc: Make AGC controls affect all channels (2023-10-24
> 09:56:52 +0100)
> 
> ----------------------------------------------------------------
> David Plowman (5):
>       ipa: rpi: hdr: Add the ability to alter the LSC table
>       ipa: rpi: alsc: Do not re-read the alsc.status metadata
>       ipa: rpi: agc: Allow AGC channels to avoid using "fast desaturation"
>       ipa: rpi: agc: Fetch AWB status in the prepare method
>       ipa: rpi: agc: Make AGC controls affect all channels
> 
> Naushir Patuck (1):
>       ipa: rpi: vc4: Move denoise control handling into the VC4 derived IPA
> 
>  src/ipa/rpi/common/ipa_base.cpp            |  55
> +++++++------------------------
>  src/ipa/rpi/controller/agc_algorithm.h     |  11 +++----
>  src/ipa/rpi/controller/rpi/agc.cpp         |  51 ++++++++++++++---------------
>  src/ipa/rpi/controller/rpi/agc.h           |  13 +++-----
>  src/ipa/rpi/controller/rpi/agc_channel.cpp |  23 +++++++------
>  src/ipa/rpi/controller/rpi/agc_channel.h   |   1 +
>  src/ipa/rpi/controller/rpi/alsc.cpp        |  22 ++++---------
>  src/ipa/rpi/controller/rpi/hdr.cpp         | 183
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------
>  src/ipa/rpi/controller/rpi/hdr.h           |  18 +++++++----
>  src/ipa/rpi/vc4/vc4.cpp                    |  35 ++++++++++++++++++--
>  10 files changed, 237 insertions(+), 175 deletions(-)