[libcamera-devel] [PATCH v1 1/1] Android adapter: CameraDevice fixes shared internal buffer

Harvey Yang chenghaoyang at chromium.org
Wed Sep 13 17:20:50 CEST 2023


From: Harvey Yang <chenghaoyang at chromium.org>

In CameraDevice::processCaptureRequest, we might need to add an internal
buffer for Mapped streams. This patch fixes a case that more than one
Mapped streams depend on a stream that is not requested in one capture
request.

Change-Id: I37a1bcc9c4c2db666a90d74c39883ff18ed11bd5
Signed-off-by: Harvey Yang <chenghaoyang at chromium.org>
---
 src/android/camera_device.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index 1f7ce440..25cedd44 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -1077,7 +1077,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques
 		descriptor->request_->addBuffer(sourceStream->stream(),
 						frameBuffer, nullptr);
 
-		requestedStreams.erase(sourceStream);
+		requestedStreams.insert(sourceStream);
 	}
 
 	/*
-- 
2.42.0.283.g2d96d420d3-goog



More information about the libcamera-devel mailing list