[libcamera-devel] [PATCH v3 2/4] android: Import GraphicBufferAllocator header from vndk v33

[Mattijs Korpershoek]

Hi Laurent,

Thank you for your review.

On dim., sept. 24, 2023 at 18:53, Laurent Pinchart <laurent.pinchart at ideasonboard.com> wrote:

> Hi Mattijs,
>
> Thank you for the patch.
>
> On Sat, Sep 23, 2023 at 06:23:32PM +0200, Mattijs Korpershoek via libcamera-devel wrote:
>> The GraphicBufferAllocator class (from libui) provides a more modern interface
>> to Android buffer allocation.
>> 
>> Moreover, the gralloc.h API has been deprecated since Android P (9).
>> 
>> Import the GraphicBufferAllocator.h from the VNDK.
>> 
>> These have been imported from:
>> URL: https://android.googlesource.com/platform/prebuilts/vndk/v33/
>> rev: 390028a9da88 ("Update VNDK snapshot v33 to build 9948968. am: 3042508aee am: 7092391a46")
>
> Same comments as for patch 1/4.

ACK.

>
>> No changes have been made to the files, besides adding the SPDX comment.
>> 
>> Note: because GraphicBufferAllocator has lots of Android-specific dependencies,
>> a future patch is needed to stub/simplify this include.
>
> I fear we'll soon reach a point where it won't be possible anymore to
> compile-test this code without a full VNDK. We'll see.

That's possible indeed. I think it would be really nice to enable
NDK/VNDK based builds as standalone but doing that and documenting it is
a bit out of scope for this series, imho.

I will investigate building with NDK/VNDK again in the coming month.

>
>> Signed-off-by: Mattijs Korpershoek <mkorpershoek at baylibre.com>
>> ---
>>  .../libs/ui/include/ui/GraphicBufferAllocator.h    | 111 +++++++++++++++++++++
>>  1 file changed, 111 insertions(+)
>
> -- 
> Regards,
>
> Laurent Pinchart