[PATCH v6 09/18] libcamera: ipa: add Soft IPA

[Milan Zamazal]

Andrei Konovalov <andrey.konovalov.ynk at gmail.com> writes:

> On 27.03.2024 19:38, Laurent Pinchart wrote:

>>> +	     libcamera.ControlInfoMap sensorCtrlInfoMap)
>>> +		=> (int32 ret);
>>> +	start() => (int32 ret);
>>> +	stop();
>>> +	configure(libcamera.ControlInfoMap sensorCtrlInfoMap)
>>> +		=> (int32 ret);
>>> +
>>> +	[async] processStats(libcamera.ControlList sensorControls);
>>> +};
>>> +
>>> +interface IPASoftEventInterface {
>>> +	setSensorControls(libcamera.ControlList sensorControls);
>>> +	setIspParams(int32 dummy);
>> Drop the dummy value.
>
> libcamera docs do allow signals with zero parameters.
> But when I tried having zero parameters for an EventInterface function,
> it didn't work for me iirc.
> Let me double check.

When the parameter is not present, the following code is generated:

  void IPAProxySoft::setIspParamsIPC(
          std::vector<uint8_t>::const_iterator data,
          size_t dataSize,
          [[maybe_unused]] const std::vector<SharedFD> &fds)
  {




          setIspParams.emit();
  }

And then the compiler complains:

  src/libcamera/proxy/soft_ipa_proxy.cpp: In member function ‘void libcamera::ipa::soft::IPAProxySoft::setIspParamsIPC(std::vector<unsigned char>::const_iterator, size_t, const std::vector<libcamera::SharedFD>&)’:
  src/libcamera/proxy/soft_ipa_proxy.cpp:416:46: error: unused parameter ‘data’ [-Werror=unused-parameter]
    416 |         std::vector<uint8_t>::const_iterator data,
        |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
  src/libcamera/proxy/soft_ipa_proxy.cpp:417:16: error: unused parameter ‘dataSize’ [-Werror=unused-parameter]
    417 |         size_t dataSize,
        |         ~~~~~~~^~~~~~~~
  cc1plus: all warnings being treated as errors

Regards,
Milan