[PATCH v6 12/18] libcamera: pipeline: simple: enable use of Soft ISP and Soft IPA

[Laurent Pinchart]

On Tue, Apr 02, 2024 at 04:10:57PM +0200, Milan Zamazal wrote:
> Laurent Pinchart <laurent.pinchart at ideasonboard.com> writes:
> 
> >> @@ -1290,8 +1363,13 @@ void SimplePipelineHandler::stopDevice(Camera *camera)
> >>  	SimpleCameraData *data = cameraData(camera);
> >>  	V4L2VideoDevice *video = data->video_;
> >>  
> >> -	if (data->useConversion_)
> >> -		data->converter_->stop();
> >> +	if (data->useConversion_) {
> >> +		if (data->converter_)
> >> +			data->converter_->stop();
> >> +		else if (data->swIsp_) {
> >> +			data->swIsp_->stop();
> >> +		}
> >
> > No need for curly braces, and same comment regarding the else if.
> 
> As for the outer ones, my compiler requires them to prevent nested if-else
> confusion.

Yes, I meant the inner ones only, I have probably misread the code
initially. Sorry about that.

-- 
Regards,

Laurent Pinchart