[PATCH v6 17/18] libcamera: software_isp: Apply black level compensation

[Laurent Pinchart]

Hi Milan,

On Tue, Apr 02, 2024 at 09:48:34PM +0200, Milan Zamazal wrote:
> Laurent Pinchart <laurent.pinchart at ideasonboard.com> writes:
> 
> > As this patch may need more work, I propose not including it in v7 to
> > avoid delay merging the rest of the implementation.
> 
> I think David and I have provided sufficient additional information to make the
> decision.  I'll keep the patch in v7 but it will be the last patch in the series
> again so it's easy to either take or omit it.

Thank you.

> [...]
> 
> >> +class BlackLevel
> >
> > Wouldn't it be better to move to using the libipa Algorithm class before
> > introducing new algorithms ?
> 
> I suppose we will need this sooner or later but it will need a non-trivial
> amount of work to integrate software ISP with this in a meaningful way and to
> decide how to de-wire exposure, white balance, and possibly black level from the
> current code, without wasting the precious CPU cycles.

The CPU-intensive part is the image processing itself, the IPA side
should hopefully not be an issue, even if we complexify it a little bit
by using the more modular architecture that the Algorithm class
provides.

-- 
Regards,

Laurent Pinchart