[PATCH v6 09/18] libcamera: ipa: add Soft IPA

[Milan Zamazal]

Andrei Konovalov <andrey.konovalov.ynk at gmail.com> writes:

> I've reused some of your changes in the branch I've pushed:
> https://gitlab.freedesktop.org/camera/libcamera-softisp/-/commits/SoftwareISP-v10-candidate-ynk1/?ref_type=heads
>
> It is based on
> https://gitlab.freedesktop.org/mzamazal/libcamera-softisp/-/commits/SoftwareISP-v10?ref_type=heads
> I've only updated the commits:
>   "libcamera: ipa: add Soft IPA"
>   "libcamera: introduce SoftwareIsp"
> and also rebased
>   "libcamera: software_isp: Apply black level compensation"
> as it depends on the changes to the other two.

Hi Andrei,

nice work, thank you!  I integrated your changes into my branch (I just fixed
one trivial typo in a comment), which is now available also at
https://gitlab.freedesktop.org/camera/libcamera-softisp/-/tree/SoftwareISP-v10?ref_type=heads

I'll post v7 soon.

Regards,
Milan

> The updated patchset still doesn't use the IPA configuration file, but it parses it and prints
> the version read from the config file if debug messages are enabled for the IPASoft category.
> If one runs libcamera without installing it, LIBCAMERA_IPA_CONFIG_PATH environment variable should be
> set properly (LIBCAMERA_IPA_CONFIG_PATH=${the_install_dir}/share/libcamera/ipa).
> I've figured out why I had problems with libcamera failing to find the IPA config file. Now this part works OK,
> no hacks were needed.
>
> As I wrote earlier, this version still doesn't have the pools of buffers for the params and the stats.
> This is in my todo list, but I don't have the date for this yet.
>
> Thanks,
> Andrei