[PATCH 2/5] utils: tuning: rkisp1: Add skeletal AGC to the rkisp1 tuning script

[Stefan Klug]

Hi Paul,

thanks for the patch.
Looks good to me.

Reviewed-by: Stefan Klug <stefan.klug at ideasonboard.com> 

Cheers,
Stefan

On Fri, Apr 05, 2024 at 11:53:32PM +0900, Paul Elder wrote:
> Add the skeletal AGC module to the rkisp1 tuning script. For now it just
> spits out hardcoded values.
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> ---
>  utils/tuning/rkisp1.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py
> index 1cea6ddb..d42646de 100755
> --- a/utils/tuning/rkisp1.py
> +++ b/utils/tuning/rkisp1.py
> @@ -11,6 +11,7 @@ import libtuning as lt
>  from libtuning.parsers import YamlParser
>  from libtuning.generators import YamlOutput
>  from libtuning.modules.lsc import LSCRkISP1
> +from libtuning.modules.agc import AGCRkISP1
>  
>  tuner = lt.Tuner('RkISP1')
>  tuner.add(LSCRkISP1(
> @@ -32,9 +33,10 @@ tuner.add(LSCRkISP1(
>            # values.  This can also be a custom function.
>            smoothing_function=lt.smoothing.MedianBlur(3),
>            ))
> +tuner.add(AGCRkISP1(debug=[lt.Debug.Plot], hw_rev='V10'))
>  tuner.set_input_parser(YamlParser())
>  tuner.set_output_formatter(YamlOutput())
> -tuner.set_output_order([LSCRkISP1])
> +tuner.set_output_order([AGCRkISP1, LSCRkISP1])
>  
>  if __name__ == '__main__':
>      sys.exit(tuner.run(sys.argv))
> -- 
> 2.39.2
>