[PATCH 4/5] utils: tuning: rkisp1: Add skeletal CTK to the rkisp1 tuning script
Stefan Klug
stefan.klug at ideasonboard.com
Fri Apr 12 10:12:33 CEST 2024
Hi Paul,
thank you for the patch.
On Fri, Apr 05, 2024 at 11:53:34PM +0900, Paul Elder wrote:
> Add the skeletal CTK module to the rkisp1 tuning script. For now it just
> spits out hardcoded values.
Sounds a bit harsh to me, but I'm not a native speaker. So I'm the wrong
one to judge here :-)
Otherwise looks good to me.
Reviewed-by: Stefan Klug <stefan.klug at ideasonboard.com>
Cheers,
Stefan
>
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> ---
> utils/tuning/rkisp1.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py
> index d42646de..e08ddf02 100755
> --- a/utils/tuning/rkisp1.py
> +++ b/utils/tuning/rkisp1.py
> @@ -12,6 +12,7 @@ from libtuning.parsers import YamlParser
> from libtuning.generators import YamlOutput
> from libtuning.modules.lsc import LSCRkISP1
> from libtuning.modules.agc import AGCRkISP1
> +from libtuning.modules.ccm import CTKRkISP1
>
> tuner = lt.Tuner('RkISP1')
> tuner.add(LSCRkISP1(
> @@ -34,9 +35,10 @@ tuner.add(LSCRkISP1(
> smoothing_function=lt.smoothing.MedianBlur(3),
> ))
> tuner.add(AGCRkISP1(debug=[lt.Debug.Plot], hw_rev='V10'))
> +tuner.add(CTKRkISP1(debug=[lt.Debug.Plot]))
> tuner.set_input_parser(YamlParser())
> tuner.set_output_formatter(YamlOutput())
> -tuner.set_output_order([AGCRkISP1, LSCRkISP1])
> +tuner.set_output_order([AGCRkISP1, LSCRkISP1, CTKRkISP1])
>
> if __name__ == '__main__':
> sys.exit(tuner.run(sys.argv))
> --
> 2.39.2
>
More information about the libcamera-devel
mailing list