[PATCH v8 05/18] libcamera: shared_mem_object: Rename SIZE constant to `size'

Milan Zamazal mzamazal at redhat.com
Tue Apr 16 11:13:41 CEST 2024


The SharedMemObject has been imported directly into the libcamera
internal components. Adapt the SIZE constant of the class to match the
libcamera coding style.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
---
 include/libcamera/internal/shared_mem_object.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h
index 98636b44..a9970059 100644
--- a/include/libcamera/internal/shared_mem_object.h
+++ b/include/libcamera/internal/shared_mem_object.h
@@ -23,7 +23,7 @@ template<class T>
 class SharedMemObject
 {
 public:
-	static constexpr std::size_t SIZE = sizeof(T);
+	static constexpr std::size_t kSize = sizeof(T);
 
 	SharedMemObject()
 		: obj_(nullptr)
@@ -45,11 +45,11 @@ public:
 		if (!fd_.isValid())
 			return;
 
-		ret = ftruncate(fd_.get(), SIZE);
+		ret = ftruncate(fd_.get(), kSize);
 		if (ret < 0)
 			return;
 
-		mem = mmap(nullptr, SIZE, PROT_READ | PROT_WRITE, MAP_SHARED,
+		mem = mmap(nullptr, kSize, PROT_READ | PROT_WRITE, MAP_SHARED,
 			   fd_.get(), 0);
 		if (mem == MAP_FAILED)
 			return;
@@ -69,7 +69,7 @@ public:
 	{
 		if (obj_) {
 			obj_->~T();
-			munmap(obj_, SIZE);
+			munmap(obj_, kSize);
 		}
 	}
 
-- 
2.42.0



More information about the libcamera-devel mailing list