[PATCH v1 4/5] docker: Install appsink element

[Laurent Pinchart]

On Thu, Mar 07, 2024 at 10:51:15PM +0000, Kieran Bingham wrote:
> Quoting Kieran Bingham (2024-03-07 22:36:15)
> > Quoting Nicolas Dufresne (2024-03-07 22:18:09)
> > > From: Nicolas Dufresne <nicolas.dufresne at collabora.com>
> > > 
> > > Some new tests required appsink element. Install the required package.
> > > 
> > > Signed-off-by: Nicolas Dufresne <nicolas.dufresne at collabora.com>
> > > ---
> > >  .gitlab-ci/setup-container.sh | 1 +
> > >  gitlab-ci.yml                 | 6 +++---
> > >  2 files changed, 4 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/.gitlab-ci/setup-container.sh b/.gitlab-ci/setup-container.sh
> > > index 6027433..29cdd2a 100755
> > > --- a/.gitlab-ci/setup-container.sh
> > > +++ b/.gitlab-ci/setup-container.sh
> > > @@ -55,6 +55,7 @@ PKGS_LIBCAMERA_RUNTIME=(
> > >  )
> > >  
> > >  PKGS_LIBCAMERA_RUNTIME_MULTIARCH=(
> > > +       gstreamer1.0-plugins-base
> > >         libdrm-dev
> > >         libdw-dev
> > >         libexif-dev
> > > diff --git a/gitlab-ci.yml b/gitlab-ci.yml
> > > index 105971d..8f455da 100644
> > > --- a/gitlab-ci.yml
> > > +++ b/gitlab-ci.yml
> > > @@ -53,17 +53,17 @@ include:
> > >  .libcamera-ci.debian:10:
> > >    variables:
> > >      FDO_DISTRIBUTION_VERSION: 'buster'
> > > -    FDO_DISTRIBUTION_TAG: '2024-01-09.2'
> > > +    FDO_DISTRIBUTION_TAG: '2024-04-07.3'
> > >  
> > >  .libcamera-ci.debian:12:
> > >    variables:
> > >      FDO_DISTRIBUTION_VERSION: 'bookworm'
> > > -    FDO_DISTRIBUTION_TAG: '2024-01-09.1'
> > > +    FDO_DISTRIBUTION_TAG: '2024-04-07.3'
> > >  
> > >  .libcamera-ci.debian:13:
> > >    variables:
> > >      FDO_DISTRIBUTION_VERSION: 'trixie'
> > > -    FDO_DISTRIBUTION_TAG: '2024-01-09.0'
> > > +    FDO_DISTRIBUTION_TAG: '2024-04-07.3'
> > 
> > These were previously .0, .1, .2, and now they're all .3. What's the
> > significance of that ? Any potential issues? Is this just bumping the
> > tag to make sure the image gets rebuilt fully?
> > 
> 
> As I understand these are just tags to track the build idnetifier, so
> updating these will trigger the rebuild against the new package
> additions so:

The .x suffix is meant to support creating multiple images per day. They
should have been set to .0 here. It's nothing that requires fixing, but
new updates to this file shouldn't use .4.

> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> 
> > >  
> > >  .container-debian:
> > >    extends:

-- 
Regards,

Laurent Pinchart