[PATCH 1/2] pipeline: rkisp1: Use cached Request pointer

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu Apr 18 12:11:52 CEST 2024


Hi Umang,

Thank you for the patch.

On Thu, Apr 18, 2024 at 01:19:44PM +0530, Umang Jain wrote:
> The Request pointer is cached in RkISP1FrameInfo. Use it directly
> instead of retrieving it via buffer->request().

https://cbea.ms/git-commit/#why-not-how

> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index abb21968..5a6c9e1e 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -1261,7 +1261,7 @@ void PipelineHandlerRkISP1::bufferReady(FrameBuffer *buffer)
>  		return;
>  
>  	const FrameMetadata &metadata = buffer->metadata();
> -	Request *request = buffer->request();
> +	Request *request = info->request;
>  
>  	if (metadata.status != FrameMetadata::FrameCancelled) {
>  		/*

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list