[PATCH] utils: checkstyle.py: Warn when no valid Signed-off-by line is found

[Kieran Bingham]

Quoting Quentin Schulz (2024-08-05 11:46:24)
> Hi Milan,
> 
> On 8/5/24 12:43 PM, Milan Zamazal wrote:
> > Laurent Pinchart <laurent.pinchart at ideasonboard.com> writes:
> > 
> >> All commits to libcamera must include a Signed-off-by line, and that
> >> rule is enforced through git hooks and CI. This however doesn't prevent
> >> patches from being submitted without an SoB tag, as noticed multiple
> >> times in the past. Extend the checkstyle.py trailer checker to issue a
> >> warning when the SoB line is missing to try and improve the situation.
> >>
> >> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > 
> > Reviewed-by: Milan Zamazal <mzamazal at redhat.com>
> > 
> > Now how to check that checkstyle.py has been run before a patch is
> > submitted. ;-)
> > 
> 
> b4 can do this (though still on client side).
> 
> b4 prep --check
> 
> if you don't run it once before b4 send is called, it'll complain (but 
> not force you to run it).
> 
> c.f. b4.prep-perpatch-check-cmd in 
> https://b4.docs.kernel.org/en/latest/config.html#contributor-oriented-settings

I always keep the checkstyle hooks as a post-commit hook. I find this the
best way (for me) as it will always run while developing, and provide me
with fast feedback - but not prevent me from continuing in my work.

'cp ./utils/hooks/post-commit .git/hooks/'

Always running, all of the time is a great way IMO to know it's been run
before submitting ;-)

--
Kieran