[PATCH v5 18/18] libcamera: camera: Hide Camera::create() from the public API

Kieran Bingham kieran.bingham at ideasonboard.com
Wed Aug 7 13:36:02 CEST 2024


Quoting Laurent Pinchart (2024-08-05 15:36:54)
> The Camera::create() function is internal. Hide it from the public API
> documentation.

Fine with me but could also be merged with 04/18.
In fact, that already touches libcamera/camera.cpp!

Anyway, if it gets it done:


Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  src/libcamera/camera.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp
> index aca466c9ba72..382a68f7bddd 100644
> --- a/src/libcamera/camera.cpp
> +++ b/src/libcamera/camera.cpp
> @@ -821,6 +821,7 @@ void Camera::Private::setState(State state)
>   */
>  
>  /**
> + * \internal
>   * \brief Create a camera instance
>   * \param[in] d Camera private data
>   * \param[in] id The ID of the camera device
> -- 
> Regards,
> 
> Laurent Pinchart
>


More information about the libcamera-devel mailing list