[PATCH v6 5/5] libcamera: camera: Hide Camera::create() from the public API

Dan Scally dan.scally at ideasonboard.com
Wed Aug 7 17:51:08 CEST 2024


Hi Laurent

On 07/08/2024 16:44, Laurent Pinchart wrote:
> The Camera::create() function is internal. Hide it from the public API
> documentation.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---


Oops, I missed this before. I think it's broadly fine but we'll have to be pretty vigilant to catch 
any new functions with the same problem.

Reviewed-by: Daniel Scally <dan.scally at ideasonboard.com>

>   src/libcamera/camera.cpp | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp
> index aca466c9ba72..382a68f7bddd 100644
> --- a/src/libcamera/camera.cpp
> +++ b/src/libcamera/camera.cpp
> @@ -821,6 +821,7 @@ void Camera::Private::setState(State state)
>    */
>   
>   /**
> + * \internal
>    * \brief Create a camera instance
>    * \param[in] d Camera private data
>    * \param[in] id The ID of the camera device


More information about the libcamera-devel mailing list