[PATCH] libcamera: libipa: camera_sensor: Add IMX283 black level

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Thu, Aug 08, 2024 at 05:57:01PM +0100, Kieran Bingham wrote:
> Configure the default sensor black level reported by the datasheet.

s/Configure/Report/ maybe ?

> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  src/ipa/libipa/camera_sensor_helper.cpp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
> index c07b1a8dcaec..039109f9540d 100644
> --- a/src/ipa/libipa/camera_sensor_helper.cpp
> +++ b/src/ipa/libipa/camera_sensor_helper.cpp
> @@ -549,6 +549,8 @@ class CameraSensorHelperImx283 : public CameraSensorHelper
>  public:
>  	CameraSensorHelperImx283()
>  	{
> +		/* From datasheet: 0x32 at 10bits. */
> +		blackLevel_ = 3200;

It's funny that 0x32 << 6 == 3200 :-)

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>  		gainType_ = AnalogueGainLinear;
>  		gainConstants_.linear = { 0, 2048, -1, 2048 };
>  	}

-- 
Regards,

Laurent Pinchart