[PATCH v3 02/23] libcamera: ipa: ipu3: Drop ipa_interface.h header

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Aug 12 14:26:06 CEST 2024


On Wed, Jul 17, 2024 at 10:54:23AM +0200, Milan Zamazal wrote:
> From: Umang Jain <umang.jain at ideasonboard.com>
> 
> The ipa_interface.h header is already included in ipu3_ipa_interface.h
> generated from module_ipa_interface.h.tmpl. Drop it as deemed redundant.

For the reason explained in the review of 01/23, this patch should be
dropped.

> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
> ---
>  src/ipa/ipu3/ipu3.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index cdcdf1fb..dca07970 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -24,7 +24,6 @@
>  
>  #include <libcamera/control_ids.h>
>  #include <libcamera/framebuffer.h>
> -#include <libcamera/ipa/ipa_interface.h>
>  #include <libcamera/ipa/ipa_module_info.h>
>  #include <libcamera/ipa/ipu3_ipa_interface.h>
>  #include <libcamera/request.h>

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list