[PATCH 2/3] gstreamer: Generate controls from control_ids_*.yaml files

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Aug 13 21:21:21 CEST 2024


On Tue, Aug 13, 2024 at 02:40:55PM -0400, Nicolas Dufresne wrote:
> Le jeudi 08 août 2024 à 14:25 +0200, Jaslo Ziska a écrit :
> > > Inspect generally allow for pretty short description, but I do 
> > > like having the full description, specially that as long as this 
> > > element lives here, we are unlikely to pull in the GStreamer doc 
> > > generator for it. Might be worth giving a try to line breaks, 
> > > though.
> > 
> > I wasn't sure if the whole description should be included but I 
> > also like having the whole description there as one can then use 
> > the gstreamer element without consulting the libcamera 
> > documentation.
> > 
> > I looked at a few gstreamer elements (h264parse and webrtcbin) 
> > with long descriptions (it was surprisingly hard to find some) and 
> > they both did not include line breaks in the description. Should I 
> > really try to add some?
> 
> Yeah, lets leave that alone, it will be pretty finicky to get it right.

It should now be easier with "[PATCH] libcamera: controls: Improve
formatting of control descriptions in YAML", which I'll merge in a few
days to give it a chance of receiving a second review.

I'm also fine leaving line breaks for later.

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list