[PATCH v4 04/18] libcamera: software_isp: Let IPASoftSimple inherit Module
Milan Zamazal
mzamazal at redhat.com
Thu Aug 15 10:16:08 CEST 2024
The Module class is a base class for all IPA modules.
In addition, implement logPrefix() of the module for the softIPA.
Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
Reviewed-by: Daniel Scally <dan.scally at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
src/ipa/simple/soft_simple.cpp | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp
index b7746ce0..72321f44 100644
--- a/src/ipa/simple/soft_simple.cpp
+++ b/src/ipa/simple/soft_simple.cpp
@@ -30,6 +30,7 @@
#include "libipa/camera_sensor_helper.h"
#include "black_level.h"
+#include "module.h"
namespace libcamera {
LOG_DEFINE_CATEGORY(IPASoft)
@@ -54,7 +55,7 @@ static constexpr float kExposureOptimal = kExposureBinsCount / 2.0;
*/
static constexpr float kExposureSatisfactory = 0.2;
-class IPASoftSimple : public ipa::soft::IPASoftInterface
+class IPASoftSimple : public ipa::soft::IPASoftInterface, public Module
{
public:
IPASoftSimple()
@@ -76,6 +77,9 @@ public:
void processStats(const ControlList &sensorControls) override;
+protected:
+ std::string logPrefix() const override;
+
private:
void updateExposure(double exposureMSV);
@@ -421,6 +425,11 @@ void IPASoftSimple::updateExposure(double exposureMSV)
again_ = std::clamp(again_, againMin_, againMax_);
}
+std::string IPASoftSimple::logPrefix() const
+{
+ return "IPASoft";
+}
+
} /* namespace ipa::soft */
/*
--
2.44.1
More information about the libcamera-devel
mailing list