[PATCH v2 0/3] Add Face Detection Controls
Harvey Yang
chenghaoyang at chromium.org
Fri Aug 23 16:29:07 CEST 2024
Hi folks,
This series of patches adds face detection controls in the control ids,
the corresponding usages, and a c'tor of libcamera::Rectangle to
construct it easiler with face detection results.
It passed gitlab pipeline checks:
https://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1256394
This is one of the series cherry-picked from cros mtkisp7 branch.
The corresponding CLs in cros are:
https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741266
https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741267
https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669229
https://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669232
The usages in pipeline handler mtkisp7 will be added later.
The checkstyle's suggestion on the second patch is ignored, as it
changes the style of previous code.
v2:
- Squashed the fourth CL into the last patch, as it's a fix.
- Fixed CLs based on checkstyle's suggestions.
BR,
Harvey
Yudhistira Erlandinata (3):
libcamera: Add rectangle two-point constructor
libcamera: Add face detection controls
libcamera: android: Add face detection control support
include/libcamera/controls.h | 6 +++
include/libcamera/geometry.h | 10 +++++
src/android/camera_capabilities.cpp | 41 ++++++++++++++++--
src/android/camera_device.cpp | 64 +++++++++++++++++++++++++++--
src/libcamera/control_ids_core.yaml | 42 +++++++++++++++++++
src/libcamera/controls.cpp | 6 +++
src/libcamera/geometry.cpp | 11 ++++-
7 files changed, 171 insertions(+), 9 deletions(-)
--
2.46.0.295.g3b9ea8a38a-goog
More information about the libcamera-devel
mailing list