[PATCH] libcamera: controls: Fix example for ExposureValue

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sun Aug 25 03:18:07 CEST 2024


Hi Fang Hui,

Thank you for the patch.

On Fri, Aug 23, 2024 at 02:02:02PM +0800, Fang Hui wrote:
> EV = [-2, -1, 0.5, 0, 0.5, 1, 2]
> should change to
> EV = [-2, -1, -0.5, 0, 0.5, 1, 2]

Good catch.

> Change-Id: I502415bdc228a5b20798597d7366c0d54b92c145

No Change-Id please. I'll drop this line when applying the patch.

> Signed-off-by: Fang Hui <hui.fang at nxp.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/control_ids_core.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml
> index 6381970b..1b1bd950 100644
> --- a/src/libcamera/control_ids_core.yaml
> +++ b/src/libcamera/control_ids_core.yaml
> @@ -127,7 +127,7 @@ controls:
>          enabled.
>  
>          By convention EV adjusts the exposure as log2. For example
> -        EV = [-2, -1, 0.5, 0, 0.5, 1, 2] results in an exposure adjustment
> +        EV = [-2, -1, -0.5, 0, 0.5, 1, 2] results in an exposure adjustment
>          of [1/4x, 1/2x, 1/sqrt(2)x, 1x, sqrt(2)x, 2x, 4x].
>  
>          \sa AeEnable

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list