[PATCH v2 05/20] libcamera: rkisp1: Remove unused includes

[Laurent Pinchart]

On Fri, Aug 30, 2024 at 05:27:02PM +0200, Milan Zamazal wrote:
> The includes that are not used can be removed.
> 
> Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
> ---
>  src/ipa/rkisp1/algorithms/agc.h          | 1 -
>  src/ipa/rkisp1/algorithms/awb.cpp        | 2 --
>  src/ipa/rkisp1/algorithms/ccm.cpp        | 4 ----
>  src/ipa/rkisp1/algorithms/dpf.cpp        | 2 --
>  src/ipa/rkisp1/rkisp1.cpp                | 2 --
>  src/ipa/rkisp1/utils.h                   | 1 -
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 --
>  7 files changed, 14 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h
> index d64ff42c..aa86f2c5 100644
> --- a/src/ipa/rkisp1/algorithms/agc.h
> +++ b/src/ipa/rkisp1/algorithms/agc.h
> @@ -15,7 +15,6 @@
>  #include <libcamera/geometry.h>
>  
>  #include "libipa/agc_mean_luminance.h"
> -#include "libipa/histogram.h"
>  
>  #include "algorithm.h"
>  
> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp
> index b40f405f..a5972015 100644
> --- a/src/ipa/rkisp1/algorithms/awb.cpp
> +++ b/src/ipa/rkisp1/algorithms/awb.cpp
> @@ -8,8 +8,6 @@
>  #include "awb.h"
>  
>  #include <algorithm>
> -#include <cmath>
> -#include <iomanip>

I wonder if iomanip was included for std::showpoint, which needs ios.

>  
>  #include <libcamera/base/log.h>
>  
> diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp
> index ca80112a..47a8b7e5 100644
> --- a/src/ipa/rkisp1/algorithms/ccm.cpp
> +++ b/src/ipa/rkisp1/algorithms/ccm.cpp
> @@ -7,10 +7,6 @@
>  
>  #include "ccm.h"
>  
> -#include <algorithm>
> -#include <chrono>
> -#include <cmath>
> -#include <tuple>

While at it, <map> is missing.

>  #include <vector>

vector doesn't seem to be needed.

>  
>  #include <libcamera/base/log.h>
> diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp
> index 079cc2c3..94080b28 100644
> --- a/src/ipa/rkisp1/algorithms/dpf.cpp
> +++ b/src/ipa/rkisp1/algorithms/dpf.cpp
> @@ -7,8 +7,6 @@
>  
>  #include "dpf.h"
>  
> -#include <cmath>
> -

But vector is missing here :-) So are algorithm and string.

>  #include <libcamera/base/log.h>
>  
>  #include <libcamera/control_ids.h>
> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> index 79ae9289..55269579 100644
> --- a/src/ipa/rkisp1/rkisp1.cpp
> +++ b/src/ipa/rkisp1/rkisp1.cpp
> @@ -6,8 +6,6 @@
>   */
>  
>  #include <algorithm>
> -#include <math.h>
> -#include <queue>

Here array and chrono are missing.

>  #include <stdint.h>
>  #include <string.h>
>  
> diff --git a/src/ipa/rkisp1/utils.h b/src/ipa/rkisp1/utils.h
> index 450f2244..5f38b50b 100644
> --- a/src/ipa/rkisp1/utils.h
> +++ b/src/ipa/rkisp1/utils.h
> @@ -8,7 +8,6 @@
>  #pragma once
>  
>  #include <cmath>
> -#include <limits>
>  #include <type_traits>
>  
>  namespace libcamera {
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 710d9573..5ff8eb9c 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -6,8 +6,6 @@
>   */
>  
>  #include <algorithm>
> -#include <array>
> -#include <iomanip>
>  #include <memory>
>  #include <numeric>
>  #include <queue>

Missing optional.

-- 
Regards,

Laurent Pinchart