[PATCH v2 03/20] libcamera: ipu3: Replace wrong include

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sat Aug 31 02:17:37 CEST 2024


Hi Milan,

Thank you for the patch.

On Fri, Aug 30, 2024 at 05:27:00PM +0200, Milan Zamazal wrote:
> v4l2_videodevice.h is not used but logging is imported through it.
> Remove the unused include and include log.h instead.
> 
> Signed-off-by: Milan Zamazal <mzamazal at redhat.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/pipeline/ipu3/frames.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp
> index 88eb9d05..bc0526a7 100644
> --- a/src/libcamera/pipeline/ipu3/frames.cpp
> +++ b/src/libcamera/pipeline/ipu3/frames.cpp
> @@ -7,12 +7,13 @@
>  
>  #include "frames.h"
>  
> +#include <libcamera/base/log.h>
> +
>  #include <libcamera/framebuffer.h>
>  #include <libcamera/request.h>
>  
>  #include "libcamera/internal/framebuffer.h"
>  #include "libcamera/internal/pipeline_handler.h"
> -#include "libcamera/internal/v4l2_videodevice.h"
>  
>  namespace libcamera {
>  

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list