[PATCH v2 0/1] libcamera: software_isp: Actually apply black level from tuning data

Kieran Bingham kieran.bingham at ideasonboard.com
Tue Dec 3 15:45:56 CET 2024


Quoting Milan Zamazal (2024-12-03 09:38:12)
> This is an alternative proposal fixing the black level to
> https://patchwork.libcamera.org/patch/21703/ by Robert.  This patch
> fixes just the obvious bug, the other parts of the given series,
> i.e. attempt to fix problems when switching cameras[1] or introducing
> IMX355 helper, are not covered.  This patch can be handled separately or
> incorporated into the Robert’s series or another solution may be
> proposed.
> 
> [1] I wonder whether
> https://patchwork.libcamera.org/project/libcamera/list/?series=4752
> could be related.
> 
> Changes in v2:
> - Rebased on master.

Thanks for the reviews and test tags.

CI passes, at
https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1322420 so
I've merged.

--
Kieran

> 
> Milan Zamazal (1):
>   libcamera: software_isp: Actually apply black level from tuning data
> 
>  src/ipa/simple/algorithms/blc.cpp | 7 +++++--
>  src/ipa/simple/algorithms/blc.h   | 4 ++++
>  src/ipa/simple/soft_simple.cpp    | 3 +--
>  3 files changed, 10 insertions(+), 4 deletions(-)
> 
> -- 
> 2.44.2
>


More information about the libcamera-devel mailing list