[PATCH v5 6/8] libtuning: Fix access to color member in ctt_awb.awb()

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Dec 9 03:08:54 CET 2024


Hi Stefan,

Thank you for the patch.

On Fri, Dec 06, 2024 at 03:52:26PM +0100, Stefan Klug wrote:
> Fix the access to the color temperature member of the Img object.

That's a bit terse.

> 
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>
> ---
>  utils/tuning/libtuning/ctt_awb.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/tuning/libtuning/ctt_awb.py b/utils/tuning/libtuning/ctt_awb.py
> index 5494bdb5c103..117612f2582a 100644
> --- a/utils/tuning/libtuning/ctt_awb.py
> +++ b/utils/tuning/libtuning/ctt_awb.py
> @@ -304,7 +304,7 @@ def get_alsc_patches(Img, colour_cals, grey=True):
>      """
>      if grey:
>          cen_coords = Img.cen_coords[3::4]
> -        col = Img.col
> +        col = Img.color

There's one similar change left in 4/8. Move it here, and

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>          patches = [np.array(Img.patches[i]) for i in Img.order]
>          r_patchs = patches[0][3::4] - Img.blacklevel_16
>          b_patchs = patches[3][3::4] - Img.blacklevel_16

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list