[PATCH v1] Enable `cpp_debugstl`

[Barnabás Pőcze]

Hi


2024. 12. 09. 11:12 keltezéssel, Laurent Pinchart írta:
> Hi Barnabás,
> 
> Thank you for the patch.
> 
> On Mon, Dec 09, 2024 at 10:51:50AM +0100, Barnabás Pőcze wrote:
>> Meson's `cpp_debugstl` built-in option enables extra checks
>> in libstdc++ and libc++, such as iterator invalidation tests,
>> bounds checking in `operator[]` of multiple types, etc by
>> setting `GLIBCXX_DEBUG` and `_LIBCPP_HARDENING_MODE`.
> 
> Could you point to a successful pipeline run with this enabled ?

Please see here:
https://gitlab.freedesktop.org/pobrn/libcamera/-/pipelines/1324797

Should I put it in the commit message?


> 
>> Signed-off-by: Barnabás Pőcze <barnabas.pocze at ideasonboard.com>
>> ---
>>   gitlab-ci.yml | 8 +++++---
>>   1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/gitlab-ci.yml b/gitlab-ci.yml
>> index ea038ec..ec96330 100644
>> --- a/gitlab-ci.yml
>> +++ b/gitlab-ci.yml
>> @@ -15,6 +15,7 @@ variables:
>>       -D android=enabled
>>       -D b_sanitize=address
>>       -D cam=enabled
>> +    -D cpp_debugstl=true
>>       -D documentation=enabled
>>       -D gstreamer=enabled
>>       -D lc-compliance=enabled
>> @@ -58,17 +59,17 @@ include:
>>   .libcamera-ci.debian:11:
>>     variables:
>>       FDO_DISTRIBUTION_VERSION: 'bullseye'
>> -    FDO_DISTRIBUTION_TAG: '2024-11-05.1'
>> +    FDO_DISTRIBUTION_TAG: '2024-12-06.1'
> 
> You only need to bump the container tag when you make changes to the
> container itself. To enable cpp_debugstl you don't need to rebuild
> containers.
> 
>>   
>>   .libcamera-ci.debian:12:
>>     variables:
>>       FDO_DISTRIBUTION_VERSION: 'bookworm'
>> -    FDO_DISTRIBUTION_TAG: '2024-11-05.1'
>> +    FDO_DISTRIBUTION_TAG: '2024-12-06.1'
>>   
>>   .libcamera-ci.debian:13:
>>     variables:
>>       FDO_DISTRIBUTION_VERSION: 'trixie'
>> -    FDO_DISTRIBUTION_TAG: '2024-11-05.1'
>> +    FDO_DISTRIBUTION_TAG: '2024-12-06.1'
>>   
>>   .container-debian:
>>     extends:
>> @@ -389,6 +390,7 @@ test-unit:
>>       MESON_OPTIONS: >-
>>         -D b_sanitize=address
>>         -D cam=disabled
>> +      -D cpp_debugstl=true
>>         -D documentation=disabled
>>         -D gstreamer=enabled
>>         -D lc-compliance=disabled
> 


Regards,
Barnabás Pőcze