[PATCH v2] V4L2VideoDevice: Call FrameBuffer::Private::cancel() in streamOff()
Harvey Yang
chenghaoyang at chromium.org
Mon Dec 9 17:34:07 CET 2024
At the moment `V4L2VideoDevice::streamOff()` sets
`FrameBuffer::Private`'s metadata directly, while that's equivalent to
calling `FrameBuffer::Private::cancel()`. To ease code tracing, this
patch replace the manual modification with the function call.
Signed-off-by: Harvey Yang <chenghaoyang at chromium.org>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
src/libcamera/v4l2_videodevice.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp
index a5cf67845..5fcebdc63 100644
--- a/src/libcamera/v4l2_videodevice.cpp
+++ b/src/libcamera/v4l2_videodevice.cpp
@@ -2007,10 +2007,9 @@ int V4L2VideoDevice::streamOff()
/* Send back all queued buffers. */
for (auto it : queuedBuffers_) {
FrameBuffer *buffer = it.second;
- FrameMetadata &metadata = buffer->_d()->metadata();
cache_->put(it.first);
- metadata.status = FrameMetadata::FrameCancelled;
+ buffer->_d()->cancel();
bufferReady.emit(buffer);
}
--
2.47.0.338.g60cca15819-goog
More information about the libcamera-devel
mailing list