[PATCH v1 3/6] Documentation: guides: pipeline-handler: Fix configuration creation
Kieran Bingham
kieran.bingham at ideasonboard.com
Tue Dec 10 14:38:13 CET 2024
Quoting Barnabás Pőcze (2024-12-09 17:48:03)
> `PipelineHandler::generateConfiguration()` returns an `std::unique_ptr`.
>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Signed-off-by: Barnabás Pőcze <barnabas.pocze at ideasonboard.com>
> ---
> Documentation/guides/pipeline-handler.rst | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst
> index 1574fe738..ec5cf4d55 100644
> --- a/Documentation/guides/pipeline-handler.rst
> +++ b/Documentation/guides/pipeline-handler.rst
> @@ -799,8 +799,7 @@ derived class, and assign it to a base class pointer.
>
> .. code-block:: cpp
>
> - VividCameraData *data = cameraData(camera);
> - CameraConfiguration *config = new VividCameraConfiguration();
> + std::unique_ptr<CameraConfiguration> config = std::make_unique<VividCameraConfiguration>();
>
> A ``CameraConfiguration`` is specific to each pipeline, so you can only create
> it from the pipeline handler code path. Applications can also generate an empty
> --
> 2.47.1
>
More information about the libcamera-devel
mailing list