[PATCH v3 08/17] pipeline: rkisp1: Add ScalerMaximumCrop property

[Jacopo Mondi]

Hi Stefan

On Fri, Dec 06, 2024 at 11:13:30AM +0100, Stefan Klug wrote:
> The ScalerMaximumCrop property holds the biggest allowed ScalerCrop
> value. Add it to the rkisp1.
>
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
> Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>

Thanks
  j

>
> ---
> Changes in v2:
> - Moved one hunk to the correct patch 6/7
> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index ad556ec85a2c..098c560ca5c8 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -24,6 +24,7 @@
>  #include <libcamera/control_ids.h>
>  #include <libcamera/formats.h>
>  #include <libcamera/framebuffer.h>
> +#include <libcamera/property_ids.h>
>  #include <libcamera/request.h>
>  #include <libcamera/stream.h>
>  #include <libcamera/transform.h>
> @@ -1245,6 +1246,7 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data)
>  		controls[&controls::ScalerCrop] = ControlInfo(min,
>  							      scalerMaxCrop_,
>  							      scalerMaxCrop_);
> +		data->properties_.set(properties::ScalerCropMaximum, scalerMaxCrop_);
>  		activeCrop_ = scalerMaxCrop_;
>  	}
>
> --
> 2.43.0
>