[PATCH] ipa: rpi: cam_helper: imx708: Correct the frame integration diff value
Kieran Bingham
kieran.bingham at ideasonboard.com
Thu Dec 12 11:31:47 CET 2024
Quoting David Plowman (2024-12-12 10:24:15)
> This is the minimum permitted difference between the frame length and
> coarse exposure (both measured in lines). The correct value, taken
> from the datasheet, is 48.
Thank you,
Happy to accept an RB tag from anyone else at Raspberry Pi who might
have access to the datasheet, but also I trust you :D - and no one
outside of Raspberry Pi (well, ok maybe Sony) could comment on this so
simply:
Acked-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
Will merge later after giving a bit of time for anyone else at RPi to
comment, but I'll take no comment as an ack too!
--
Kieran
> Signed-off-by: David Plowman <david.plowman at raspberrypi.com>
> ---
> src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp
> index ec83d9fd..16a017e9 100644
> --- a/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp
> +++ b/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp
> @@ -66,7 +66,7 @@ private:
> * Smallest difference between the frame length and integration time,
> * in units of lines.
> */
> - static constexpr int frameIntegrationDiff = 22;
> + static constexpr int frameIntegrationDiff = 48;
> /* Maximum frame length allowable for long exposure calculations. */
> static constexpr int frameLengthMax = 0xffdc;
> /* Largest long exposure scale factor given as a left shift on the frame length. */
> --
> 2.39.5
>
More information about the libcamera-devel
mailing list