[PATCH v2 1/2] gstreamer: allocator: gst_libcamera_allocator_new(): Recognize errors

[Laurent Pinchart]

Hi Barnabás,

Thank you for the patch.

On Mon, Dec 16, 2024 at 10:47:07AM +0000, Barnabás Pőcze wrote:
> `FrameBufferAllocator::allocate()` might return a negative error code,
> but currently this is handled the same way as success. So instead
> of continuing, abort the construction of the allocator object.
> 
> Signed-off-by: Barnabás Pőcze <pobrn at protonmail.com>

I think you missed my R-b tag from v1.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/gstreamer/gstlibcameraallocator.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp
> index 7e4c904da..b0c84893a 100644
> --- a/src/gstreamer/gstlibcameraallocator.cpp
> +++ b/src/gstreamer/gstlibcameraallocator.cpp
> @@ -214,7 +214,7 @@ gst_libcamera_allocator_new(std::shared_ptr<Camera> camera,
>  		Stream *stream = streamCfg.stream();
>  
>  		ret = self->fb_allocator->allocate(stream);
> -		if (ret == 0)
> +		if (ret <= 0)
>  			return nullptr;
>  
>  		GQueue *pool = g_queue_new();

-- 
Regards,

Laurent Pinchart