[PATCH v4 15/20] pipeline: rkisp1: Enable the dewarper unconditionally
Stefan Klug
stefan.klug at ideasonboard.com
Mon Dec 16 16:40:55 CET 2024
In configure() and in the future in generateConfiguration() the
calculated stream sizes and crop rectangles depend on the dewarper being
used or not. It is therefore not possible to postpone that decision
until the dewarper gets configured. Enable the dewarper unconditionally
if it is found and the stream type is not RAW.
Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>
---
Changes in v4:
- Collected tags
---
src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
index 18038226912a..14d4bb9a929b 100644
--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
@@ -865,7 +865,10 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)
if (dewarper_ && !isRaw_) {
outputCfgs.push_back(const_cast<StreamConfiguration &>(cfg));
ret = dewarper_->configure(cfg, outputCfgs);
- useDewarper_ = ret ? false : true;
+ if (ret)
+ return ret;
+
+ useDewarper_ = true;
/*
* Calculate the crop rectangle of the data
--
2.43.0
More information about the libcamera-devel
mailing list