[PATCH] libcamera: camera_sensor_properties: ov5675: Set correct delays

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Thu, Dec 19, 2024 at 12:59:58AM +0000, Kieran Bingham wrote:
> The OV5675 uses different delays for gain and exposure than are configured
> in the default sensorDelays utilised by the CameraSensorLegacy.
> 
> Empirical testing using a Lenovo X13s shows that the exposure delay is
> only a single frame, and the current setting of 2 frame delay produces
> exceedingly frequent oscillations in the image exposure.

Have you been able to test the other delays ? If not I'd like at least a
comment here that indicates this needs to be checked.

Any volunteer to write a measurement tool ?

> Update the OV5675 sensor delays table accordingly.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  src/libcamera/sensor/camera_sensor_properties.cpp | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp
> index bd1fc86977ce..813878386a35 100644
> --- a/src/libcamera/sensor/camera_sensor_properties.cpp
> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp
> @@ -360,7 +360,12 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>  				{ controls::draft::TestPatternModeOff, 0 },
>  				{ controls::draft::TestPatternModeColorBars, 1 },
>  			},
> -			.sensorDelays = { },
> +			.sensorDelays = {
> +				.exposureDelay = 1,
> +				.gainDelay = 1,
> +				.vblankDelay = 2,
> +				.hblankDelay = 2
> +			    },
>  		} },
>  		{ "ov5693", {
>  			.unitCellSize = { 1400, 1400 },

-- 
Regards,

Laurent Pinchart