[RFC PATCH v1] libcamera: virtual: Install configuration file

[Cheng-Hao Yang]

Hi Barnabás,

Thanks for handling this!

Reviewed-by: Harvey Yang <chenghaoyang at chromium.org>

On Thu, Dec 19, 2024 at 8:49 PM Kieran Bingham
<kieran.bingham at ideasonboard.com> wrote:
>
> Quoting Barnabás Pőcze (2024-12-19 12:37:24)
> > Install the example configuration file of the virtual pipeline
> > handler as it serves documentation purposes, and to make the
> > virtual pipeline handler easily usable in CI.
> >
> > Nonetheless, the file is installed with the ".example" suffix
> > so that it will not be used by default, to avoid cluttering
> > the camera lists of users whose distributions decide to
> > enable the virtual pipeline handler.
> >
> > Signed-off-by: Barnabás Pőcze <pobrn at protonmail.com>
> > ---
> >  src/libcamera/pipeline/virtual/data/meson.build | 4 ++++
> >  src/libcamera/pipeline/virtual/meson.build      | 2 ++
> >  2 files changed, 6 insertions(+)
> >  create mode 100644 src/libcamera/pipeline/virtual/data/meson.build
> >
> > diff --git a/src/libcamera/pipeline/virtual/data/meson.build b/src/libcamera/pipeline/virtual/data/meson.build
> > new file mode 100644
> > index 000000000..ce63f9a27
> > --- /dev/null
> > +++ b/src/libcamera/pipeline/virtual/data/meson.build
> > @@ -0,0 +1,4 @@
> > +install_data('virtual.yaml',
> > +             install_dir : pipeline_data_dir / 'virtual',
> > +             install_tag : 'runtime',
> > +             rename: 'virtual.yaml.example')
>
> Oh that's a very neat way to handle this.
>
> > diff --git a/src/libcamera/pipeline/virtual/meson.build b/src/libcamera/pipeline/virtual/meson.build
> > index 4786fe2e0..c84345936 100644
> > --- a/src/libcamera/pipeline/virtual/meson.build
> > +++ b/src/libcamera/pipeline/virtual/meson.build
> > @@ -11,3 +11,5 @@ libjpeg = dependency('libjpeg', required : true)
> >
> >  libcamera_deps += [libyuv_dep]
> >  libcamera_deps += [libjpeg]
> > +
> > +subdir('data')
>
> I think we normally handle subdir calls early in the meson.build, but I
> think this is fine too.
>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>
> > --
> > 2.47.1
> >
> >