[PATCH] libcamera: add missing <stdint.h> include to dma_buf_allocator.h
Sergei Trofimovich
slyich at gmail.com
Mon Dec 30 23:27:39 CET 2024
On Mon, 30 Dec 2024 23:41:10 +0200
Laurent Pinchart <laurent.pinchart at ideasonboard.com> wrote:
> Hi Sergei,
>
> Thank you for the patch.
>
> On Sat, Dec 28, 2024 at 07:11:19PM +0000, Sergei Trofimovich wrote:
> > Without the change the build fails on upcoming `gcc-15` as:
> >
> > In file included from ../src/libcamera/dma_buf_allocator.cpp:9:
> > ../include/libcamera/internal/dma_buf_allocator.h:66:19: error: 'uint64_t' has not been declared
> > 66 | void sync(uint64_t step);
> > | ^~~~~~~~
>
>
> The patch is missing your Signed-off-by line. Please see
> https://libcamera.org/contributing.html#submitting-patches. Apart from
> that, everything looks good.
>
> Could you please either resubmit the patch with the missing SoB line, or
> reply to this mail thread with the SoB ?
Ah, my apologies! Adding SoB as an email reply:
Signed-off-by: Sergei Trofimovich <slyich at gmail.com>
> > ---
> > include/libcamera/internal/dma_buf_allocator.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/libcamera/internal/dma_buf_allocator.h b/include/libcamera/internal/dma_buf_allocator.h
> > index fc5de2c1..56341470 100644
> > --- a/include/libcamera/internal/dma_buf_allocator.h
> > +++ b/include/libcamera/internal/dma_buf_allocator.h
> > @@ -8,6 +8,7 @@
> > #pragma once
> >
> > #include <memory>
> > +#include <stdint.h>
> > #include <string>
> > #include <vector>
> >
>
> --
> Regards,
>
> Laurent Pinchart
--
Sergei
More information about the libcamera-devel
mailing list