Recommended control V4L2_CID_IMAGE_STABILIZATION missing libcamera message

[Jacopo Mondi]

On Sun, Feb 04, 2024 at 10:45:55AM +0200, Laurent Pinchart wrote:
> On Sun, Feb 04, 2024 at 08:44:01AM +0100, Hans de Goede wrote:
> > Hi All,
> >
> > While working on the ov2680 driver to make it work with libcamera, I noticed
> > that after adding vblank + hblank control I still get a message about
> > Recommended V4control V4L2_CID_IMAGE_STABILIZATION missing libcamera message
> > with a pointer to Documentation/sensor_driver_requirements.rst where
> > this is not documented.
>
> That's not expected, libcamera doesn't require that control. 'git grep
> IMAGE_STABILIZATION' returns a single hit, in
> include/linux/v4l2-controls.h. Could you try to figure out what's
> happening ?
>


The only recommanded control I see is
#define V4L2_CID_CAMERA_ORIENTATION		(V4L2_CID_CAMERA_CLASS_BASE+34)

While
#define V4L2_CID_IMAGE_STABILIZATION		(V4L2_CID_CAMERA_CLASS_BASE+22)

is it by chance that 22h = 34d ?


> > So what should be done about this warning on sensor drivers where
> > image stabilization is not supported. Have it in read-only form
> > and then always report false ?
>
> --
> Regards,
>
> Laurent Pinchart